Hojun-Cho
dadda19b3a
grabrepeat was an empty body, and under the grab the compositor feeds the client nothing while a key is down: one press, then only repeat_info, leaving the repeat to whoever holds the grab. So a key strans ate acted once however long it was held. Hold Backspace over a syllable and one jamo goes; hold a jamo key and you get one where every other window gives four a second. X11 has none of this -- the server auto-repeats and xim.c dispatches every press -- so the same keyboard behaved differently depending on which frontend the window went through. Under headless sway, which advertises repeat_info(25, 600), holding Backspace 1.5s over 라 with 가가가나다 committed behind it: before preedit 라 -> ㄹ, and no key at the client at all after preedit 라 -> ㄹ -> empty, then 9 BackSpace at the client fcitx5 and kime both keep driving the repeat after the engine stops wanting the key, and both then must send a release before every press, or the client sees a key held down and starts a repeat of its own on top of theirs. That machinery exists only to undo the choice that created it. strans does not need it: forward() already hands a key the engine did not take to the client as a key, and the client repeats that correctly -- the same hold with nothing pending, which takes that untouched path, delivers 24. So the rule is one sentence. strans repeats what the engine takes; when the engine stops taking it, presskey has already passed the key on, the deadline is dropped, and the client repeats it from there. 9 against 24 is that handover: driving every tick here would have made them one number. It costs one pause of the client's own delay, 600ms, where the preedit empties. It buys no release-and-press fiction anywhere in the file, no second repeat engine, and no timestamp arithmetic -- exactly one key is forwarded per hold, so there is no run of stale timestamps to mend. nsec() is gettimeofday, which steps; a deadline wants the clock ipc.c already uses. The owner poll stands down while a key repeats, because the repeat's own Keypress carries our owner and takes the engine back, so it would have nothing to find. Arming needs the engine and cannot be reached from the unit suite; ending a repeat can, and a repeat outliving its key is the worst this could do. wl/repeat-ends was checked by breaking it five ways -- a constant rate, a constant delay, the empty body back again, the key's own release no longer ending it, and a repeat into a dead context staying armed -- each failing only its own line. Phases A-G unchanged at both scales; 90 unit, check-live, check-stress and valgrind clean. One limit worth writing down: the GTK probe prints the BackSpace it receives and never deletes on one, on this path or on the plain pass-through, so the phase proves the keys arrive and says nothing about the text behind them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
6.6 KiB
6.6 KiB