Files
ww/test/wcc/989_ampfncollide_run.c
Hojun-Cho ce3a25a0b4 test: contain sepwork scratch per-driver tmpdir, fix /tmp+in-repo leak (#8)
The wcc test drivers ran `ww build <bare-/tmp src>` with no -o, so the
compiler's <stem>.sepwork scratch landed beside the source and was never
cleaned: unbounded /tmp growth (2195 stale dirs observed) that fills tmpfs
and fabricates phantom test failures + silent harness aborts, and for
in-repo fixture builds leaked .sepwork into the tracked tree.

Each leaking build now writes its source + output inside a per-invocation
tmpdir, passes -o <tmpdir>/<stem> so the .sepwork lands inside it, and
rm -rf's the tmpdir on every exit path -- including fopen-fail and the
expected-fail reject builds (scratch is mkdir'd before the build can fail).
`ww run` and explicit-`-o`/byte-id helpers are left as-is; the 990/993
byte-id comparison logic is byte-for-byte unchanged.

Two items filed separately (this commit holds the no-Makefile / no-main.c
rail):
- #13: a stale <src>.s byte-id readback (749) silently no-ops since
  separate-compile emits .s to <ostem>.sepwork/__root.s; documented inline.
- #14: build-system Makefile recipes build selfhost/cmd/*/main.ww with no
  -o and leak main.sepwork in-tree (bounded, gitignored; own commit).

One concern -- sepwork leak hygiene -- across 228 drivers; uniform
transform applied per-file and two-round reviewed. make test: all 402
passed, zero net-new /tmp scratch, zero test-driven in-repo .sepwork.
2026-06-22 23:29:39 +09:00

163 lines
5.0 KiB
C

/*
* 989_ampfncollide_run (#4, c2) — `&fn` synthesis must prefer the current
* module's fn when a same-leaf fn is declared in a later module.
*
* THE BUG (review item #4, 2026-06-11): unoptype's TK_AMP fn-ident synth
* (check.ww ~2677) and assignableaddrfn (check.ww ~4182) looked the fn up
* with bare scopelookup — no (name,module) preference. scopedefineinmodule
* PREPENDS, so a LATER module's same-leaf fn heads the bucket chain and the
* bare lookup binds ITS signature. Two faces:
* - LOUD: `let p: *hfn = &handler` in beta (hfn = fn(i32)i32, beta.handler
* is i32->i32) is REJECTED by wwstage ("let: not assignable") because it
* binds gamma.handler(str)str, while cstage (scope_lookup_prefer with
* cur_mod, check.c:410/1305) binds beta.handler and accepts. Valid code
* wrongly rejected.
* - SILENT (cat-A): `let p: *gfn = &handler` where gfn = fn(str)str (the
* FOREIGN sig) is REJECTED by cstage (beta.handler is i32->i32, not
* assignable) but ACCEPTED by wwstage (it binds gamma.handler(str)str,
* which matches gfn) — a type-confused fn pointer (LEAQ beta.handler
* into a *fn(str)str slot) in a green build.
* THE FIX: both sites use scopelookupprefer(c.cur, c.curmod, ...).
*
* row | shape | result (cs==ww)
* -------+-----------------------------------------+-----------------
* loud | *hfn = &handler (own-sig slot) | run 42 (was ww reject)
* silent | *gfn = &handler (foreign-sig slot) | build FAIL (was ww ok)
*
* Single-file multi-package source is the sanctioned shape (cmd/ww/main.c).
* want = -1 means "build must fail on both stages".
*/
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <sys/stat.h>
#include <sys/wait.h>
static int
runwait(const char *cmd)
{
int rc = system(cmd);
if (rc == -1) return -1;
if (WIFEXITED(rc)) return WEXITSTATUS(rc);
return -1;
}
struct row { const char *label; const char *src; int want; };
static const struct row rows[] = {
{ "loud",
"package beta;\n"
"export type hfn = fn(x: i32) i32;\n"
"export fn handler(x: i32) i32 = { return x + 41; };\n"
"export fn usebeta() i32 = {\n"
" let p: *hfn = &handler;\n"
" return (*p)(1);\n"
"};\n"
"package gamma;\n"
"export fn handler(s: str) str = { return s; };\n"
"package main;\n"
"import beta;\n"
"import gamma;\n"
"fn main() int = { return beta.usebeta(): int; };\n",
42 },
{ "silent",
"package beta;\n"
"export type gfn = fn(s: str) str;\n"
"export fn handler(x: i32) i32 = { return x + 41; };\n"
"export fn usebeta() i32 = {\n"
" let p: *gfn = &handler;\n"
" if (p == p) { return 1; };\n"
" return 0;\n"
"};\n"
"package gamma;\n"
"export fn handler(s: str) str = { return s; };\n"
"package main;\n"
"import beta;\n"
"import gamma;\n"
"fn main() int = { return beta.usebeta(): int; };\n",
-1 },
};
static int
run_build(const char *driver, const struct row *r, int i)
{
char tmpdir[64], src[128], outbin[128], rmcmd[160], cmd[1024];
snprintf(tmpdir, sizeof tmpdir, "/tmp/afc_%d_d_%d", getpid(), i);
mkdir(tmpdir, 0755);
snprintf(src, sizeof src, "%s/afc_%d_%d.ww", tmpdir, getpid(), i);
snprintf(outbin, sizeof outbin, "%s/afc_%d_%d", tmpdir, getpid(), i);
snprintf(rmcmd, sizeof rmcmd, "rm -rf %s", tmpdir);
FILE *f = fopen(src, "wb");
if (!f) { runwait(rmcmd); return -2; }
fputs(r->src, f);
fclose(f);
snprintf(cmd, sizeof cmd, "%s build -o %s %s 2>/dev/null",
driver, outbin, src);
int brc = runwait(cmd);
int got = -1;
if (brc == 0) got = runwait(outbin);
runwait(rmcmd);
return brc == 0 ? got : -1; /* -1 == build failed */
}
int
main(void)
{
const char *bin = getenv("BIN");
if (!bin) bin = "out/bin";
char absbin[1024];
if (bin[0] != '/') {
char cwd[1024];
if (getcwd(cwd, sizeof cwd) == NULL) return 1;
snprintf(absbin, sizeof absbin, "%s/%s", cwd, bin);
bin = absbin;
}
char cdrv[1024], wdrv[1024];
snprintf(cdrv, sizeof cdrv, "%s/ww", bin);
snprintf(wdrv, sizeof wdrv, "%s/ww_ww", bin);
int have_ww = (access(wdrv, X_OK) == 0);
int n = (int)(sizeof rows / sizeof rows[0]);
int total = 0, fail = 0;
for (int i = 0; i < n; i++) {
total++;
int gc = run_build(cdrv, &rows[i], i);
if (gc != rows[i].want) {
fprintf(stderr, "ampfncollide[cstage][%s]: got=%d want=%d\n",
rows[i].label, gc, rows[i].want);
fail++;
}
if (!have_ww) {
fprintf(stderr, "ampfncollide: skip wwstage (no %s)\n", wdrv);
continue;
}
int gw = run_build(wdrv, &rows[i], i);
if (gw != gc) {
fprintf(stderr, "ampfncollide[%s]: cs=%d != ww=%d "
"(&fn cross-module same-leaf misbind — #4 c2)\n",
rows[i].label, gc, gw);
fail++;
}
if (gw != rows[i].want) {
fprintf(stderr, "ampfncollide[wwstage][%s]: got=%d want=%d\n",
rows[i].label, gw, rows[i].want);
fail++;
}
}
if (fail) {
fprintf(stderr, "ampfncollide_run: %d/%d checks failed\n",
fail, total);
return 1;
}
printf("ampfncollide_run: %d/%d ok\n", total, total);
return 0;
}