Hojun-Cho
ce3a25a0b4
The wcc test drivers ran `ww build <bare-/tmp src>` with no -o, so the compiler's <stem>.sepwork scratch landed beside the source and was never cleaned: unbounded /tmp growth (2195 stale dirs observed) that fills tmpfs and fabricates phantom test failures + silent harness aborts, and for in-repo fixture builds leaked .sepwork into the tracked tree. Each leaking build now writes its source + output inside a per-invocation tmpdir, passes -o <tmpdir>/<stem> so the .sepwork lands inside it, and rm -rf's the tmpdir on every exit path -- including fopen-fail and the expected-fail reject builds (scratch is mkdir'd before the build can fail). `ww run` and explicit-`-o`/byte-id helpers are left as-is; the 990/993 byte-id comparison logic is byte-for-byte unchanged. Two items filed separately (this commit holds the no-Makefile / no-main.c rail): - #13: a stale <src>.s byte-id readback (749) silently no-ops since separate-compile emits .s to <ostem>.sepwork/__root.s; documented inline. - #14: build-system Makefile recipes build selfhost/cmd/*/main.ww with no -o and leak main.sepwork in-tree (bounded, gitignored; own commit). One concern -- sepwork leak hygiene -- across 228 drivers; uniform transform applied per-file and two-round reviewed. make test: all 402 passed, zero net-new /tmp scratch, zero test-driven in-repo .sepwork.
102 lines
2.8 KiB
C
102 lines
2.8 KiB
C
/*
|
|
* 697_samemod_prefer — same-module preference for bare-leaf lookup.
|
|
*
|
|
* Two modules each export `read` with intentionally distinct
|
|
* signatures (mod1: i32 → i32, mod2: str → i32). Each module's
|
|
* `caller()` invokes bare `read(...)` with its own arg type. The
|
|
* bare-leaf lookup must resolve to the SAME-MODULE `read`; otherwise
|
|
* the call is a check-time signature mismatch.
|
|
*
|
|
* Pre-fix (flat scope, first-wins by hash order): one of the bare
|
|
* lookups picked the wrong module's `read` and the build failed with
|
|
* "argument type not assignable". Post-fix (scope_lookup_prefer): each
|
|
* bare-leaf inside its own module binds to the same-module entry, both
|
|
* calls type-check, and the build succeeds.
|
|
*
|
|
* Runtime exit codes aren't asserted here because cgen still emits
|
|
* unmangled `TEXT read` labels for both modules and the linker
|
|
* collapses them. Mangling fn labels by module is a separate codegen
|
|
* sweep; this test pins the resolver fix alone.
|
|
*
|
|
* Fixtures live in test/wcc/data/samemodprefer/. Same shape as
|
|
* 696_modtype_leaf_collision.c.
|
|
*/
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/wait.h>
|
|
|
|
static int
|
|
runwait(const char *cmd)
|
|
{
|
|
int rc = system(cmd);
|
|
if (rc == -1) return -1;
|
|
if (WIFEXITED(rc)) return WEXITSTATUS(rc);
|
|
return -1;
|
|
}
|
|
|
|
static int
|
|
run_pos(const char *driver, const char *fixdir, const char *tag)
|
|
{
|
|
/* -o into a /tmp tmpdir so the binary AND `<stem>.sepwork/` land
|
|
* outside the repo; the cd keeps source-dir-first import search
|
|
* resolving `use mod1; use mod2;`. */
|
|
char td[1024];
|
|
snprintf(td, sizeof td, "/tmp/smprefer_%d_%s", getpid(), tag);
|
|
mkdir(td, 0755);
|
|
|
|
char rmcmd[1152];
|
|
snprintf(rmcmd, sizeof rmcmd, "rm -rf %s", td);
|
|
|
|
char cmd[2048];
|
|
snprintf(cmd, sizeof cmd,
|
|
"cd %s && %s build -o %s/pos pos.ww >/dev/null 2>&1",
|
|
fixdir, driver, td);
|
|
if (runwait(cmd) != 0) {
|
|
fprintf(stderr,
|
|
"samemod_prefer[%s]: pos.ww build failed — bare-leaf "
|
|
"`read` lookup likely cross-bound\n", tag);
|
|
runwait(rmcmd);
|
|
return 1;
|
|
}
|
|
runwait(rmcmd);
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
main(void)
|
|
{
|
|
const char *bin = getenv("BIN");
|
|
if (!bin) bin = "out/bin";
|
|
char absbin[1024];
|
|
if (bin[0] != '/') {
|
|
char cwd[1024];
|
|
if (getcwd(cwd, sizeof cwd) == NULL) return 1;
|
|
snprintf(absbin, sizeof absbin, "%s/%s", cwd, bin);
|
|
bin = absbin;
|
|
}
|
|
|
|
char cdrv[1024];
|
|
snprintf(cdrv, sizeof cdrv, "%s/ww", bin);
|
|
|
|
char fixdir[1024];
|
|
if (getcwd(fixdir, sizeof fixdir) == NULL) return 1;
|
|
size_t cwd_n = strlen(fixdir);
|
|
const char *rel = "/test/wcc/data/samemodprefer";
|
|
if (cwd_n + strlen(rel) + 1 >= sizeof fixdir) return 1;
|
|
memcpy(fixdir + cwd_n, rel, strlen(rel) + 1);
|
|
|
|
int fail = 0;
|
|
fail += run_pos(cdrv, fixdir, "cstage");
|
|
|
|
if (fail) {
|
|
fprintf(stderr,
|
|
"samemod_prefer: %d case(s) failed\n", fail);
|
|
return 1;
|
|
}
|
|
printf("samemod_prefer: 1/1 ok\n");
|
|
return 0;
|
|
}
|