Hojun-Cho
ce3a25a0b4
The wcc test drivers ran `ww build <bare-/tmp src>` with no -o, so the compiler's <stem>.sepwork scratch landed beside the source and was never cleaned: unbounded /tmp growth (2195 stale dirs observed) that fills tmpfs and fabricates phantom test failures + silent harness aborts, and for in-repo fixture builds leaked .sepwork into the tracked tree. Each leaking build now writes its source + output inside a per-invocation tmpdir, passes -o <tmpdir>/<stem> so the .sepwork lands inside it, and rm -rf's the tmpdir on every exit path -- including fopen-fail and the expected-fail reject builds (scratch is mkdir'd before the build can fail). `ww run` and explicit-`-o`/byte-id helpers are left as-is; the 990/993 byte-id comparison logic is byte-for-byte unchanged. Two items filed separately (this commit holds the no-Makefile / no-main.c rail): - #13: a stale <src>.s byte-id readback (749) silently no-ops since separate-compile emits .s to <ostem>.sepwork/__root.s; documented inline. - #14: build-system Makefile recipes build selfhost/cmd/*/main.ww with no -o and leak main.sepwork in-tree (bounded, gitignored; own commit). One concern -- sepwork leak hygiene -- across 228 drivers; uniform transform applied per-file and two-round reviewed. make test: all 402 passed, zero net-new /tmp scratch, zero test-driven in-repo .sepwork.
313 lines
9.1 KiB
C
313 lines
9.1 KiB
C
/*
|
|
* 828_overlong_arrlit — an OVERLONG array literal (more initialisers than the
|
|
* declared [N]) is INVALID ww; BOTH stages must LOUDLY REJECT at check time
|
|
* (#12 + #106; rob spec .ai/rob-12-106-spec.md). #9 wired the over-fill at the
|
|
* DECL position only; this extends checkarrlitfits to the RETURN + CALL-ARG
|
|
* positions and chases a TY_NAMED alias to its underlying [N]T at the top of
|
|
* checkarrlitfits, so EVERY caller is alias-aware by construction.
|
|
*
|
|
* WWSTAGE-ONLY fix — cstage already rejects all four shapes (type_assignable
|
|
* counts elements). Pre-fix wwstage divergences (the mutation-sanity targets):
|
|
* - #12a RETURN `fn f() [2]int = [1,2,3]` : ww silently ACCEPTED (exit 0)
|
|
* - #12b CALL-ARG `g([1,2,3])`, g(a:[2]int) : ww loud-but-LATE via cgen #271
|
|
* - #106 alias-global `type A=[2]int; let g:A=[1,2,3]` : ww silently ACCEPTED
|
|
* (+ truncated DATA)
|
|
* - alias-RETURN `type A=[2]int; fn f() A=[1,2,3]` : proves the alias
|
|
* chase covers the return too
|
|
*
|
|
* The diagnostic TEXT may differ between stages ("over-fill" vs "not
|
|
* assignable") — that is byte-id-blind (stderr is not asm); both REJECT and
|
|
* emit no asm, so 990-997 byte-id is untouched. Do NOT chase message parity.
|
|
*
|
|
* neg row | shape | gate
|
|
* -----------------+---------------------------------------------+----------
|
|
* ret_overlong | fn f() [2]int = [1,2,3] | build FAIL
|
|
* arg_overlong | fn g(a:[2]int)..; g([1,2,3]) | build FAIL
|
|
* alias_g_over | type A=[2]int; let g:A=[1,2,3] | build FAIL
|
|
* alias_ret_over | type A=[2]int; fn f() A = [1,2,3] | build FAIL
|
|
*
|
|
* pos row | shape | want
|
|
* -----------------+---------------------------------------------+------
|
|
* ret_exact | fn f() [2]int = [1,2]; f()[1] | 2
|
|
* arg_exact | fn g(a:[2]int) int = a[1]; g([10,20]) | 20
|
|
* alias_exact | type A=[2]int; let g:A=[1,2]; g[1] | 2
|
|
*/
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <unistd.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/wait.h>
|
|
|
|
static int
|
|
runwait(const char *cmd)
|
|
{
|
|
int rc = system(cmd);
|
|
if (rc == -1) return -1;
|
|
if (WIFEXITED(rc)) return WEXITSTATUS(rc);
|
|
return -1;
|
|
}
|
|
|
|
struct row { const char *label; const char *src; int want; };
|
|
|
|
static const struct row rows[] = {
|
|
{ "ret_exact",
|
|
"package main;\n"
|
|
"fn f() [2]int = {\n"
|
|
"\treturn [1, 2];\n"
|
|
"};\n"
|
|
"export fn main() i32 = {\n"
|
|
"\tlet r: [2]int = f();\n"
|
|
"\treturn r[1]: i32;\n"
|
|
"};\n",
|
|
2 },
|
|
|
|
/* A bare array-LITERAL fixed-array arg is blocked on BOTH stages by
|
|
* cgen #271 (aggregate arg from unsupported source); the supported
|
|
* valid form passes via a variable. This control confirms the #12b
|
|
* desugarcallargs over-fill wiring (gated to `a.kind == N_ARRLIT`)
|
|
* leaves a normal variable call-arg untouched. */
|
|
{ "arg_exact",
|
|
"package main;\n"
|
|
"fn g(a: [2]int) int = {\n"
|
|
"\treturn a[1];\n"
|
|
"};\n"
|
|
"export fn main() i32 = {\n"
|
|
"\tlet v: [2]int = [10, 20];\n"
|
|
"\treturn g(v): i32;\n"
|
|
"};\n",
|
|
20 },
|
|
|
|
{ "alias_exact",
|
|
"package main;\n"
|
|
"type A = [2]int;\n"
|
|
"let g: A = [1, 2];\n"
|
|
"export fn main() i32 = {\n"
|
|
"\treturn g[1]: i32;\n"
|
|
"};\n",
|
|
2 },
|
|
};
|
|
|
|
/* An overlong array literal — both stages must FAIL the build (loud checker
|
|
* diagnostic, not silent accept / DATA-truncate / late cgen loud). */
|
|
static const char *neg[] = {
|
|
/* ret_overlong (#12a) */
|
|
"package main;\n"
|
|
"fn f() [2]int = {\n"
|
|
"\treturn [1, 2, 3];\n"
|
|
"};\n"
|
|
"export fn main() i32 = {\n"
|
|
"\tlet r: [2]int = f();\n"
|
|
"\treturn r[1]: i32;\n"
|
|
"};\n",
|
|
/* arg_overlong (#12b) */
|
|
"package main;\n"
|
|
"fn g(a: [2]int) int = {\n"
|
|
"\treturn a[1];\n"
|
|
"};\n"
|
|
"export fn main() i32 = {\n"
|
|
"\treturn g([1, 2, 3]): i32;\n"
|
|
"};\n",
|
|
/* alias_g_over (#106) */
|
|
"package main;\n"
|
|
"type A = [2]int;\n"
|
|
"let g: A = [1, 2, 3];\n"
|
|
"export fn main() i32 = {\n"
|
|
"\treturn g[1]: i32;\n"
|
|
"};\n",
|
|
/* alias_ret_over (alias + return) */
|
|
"package main;\n"
|
|
"type A = [2]int;\n"
|
|
"fn f() A = {\n"
|
|
"\treturn [1, 2, 3];\n"
|
|
"};\n"
|
|
"export fn main() i32 = {\n"
|
|
"\tlet r: A = f();\n"
|
|
"\treturn r[1]: i32;\n"
|
|
"};\n",
|
|
};
|
|
|
|
static int
|
|
run_driver(const char *driver, const struct row *r, int i)
|
|
{
|
|
char src[128], tmpdir[64], outbin[128], rmcmd[160], cmd[1024];
|
|
snprintf(tmpdir, sizeof tmpdir, "/tmp/oal_%d_d_%d", getpid(), i);
|
|
mkdir(tmpdir, 0755);
|
|
snprintf(src, sizeof src, "%s/oal_%d_%d.ww", tmpdir, getpid(), i);
|
|
snprintf(outbin, sizeof outbin, "%s/oal_%d_%d", tmpdir, getpid(), i);
|
|
snprintf(rmcmd, sizeof rmcmd, "rm -rf %s", tmpdir);
|
|
|
|
FILE *f = fopen(src, "wb");
|
|
if (!f) { runwait(rmcmd); return -1; }
|
|
fputs(r->src, f);
|
|
fclose(f);
|
|
|
|
snprintf(cmd, sizeof cmd, "%s build -o %s %s 2>/dev/null",
|
|
driver, outbin, src);
|
|
if (runwait(cmd) != 0) {
|
|
fprintf(stderr, "row[%s]: build via %s failed\n",
|
|
r->label, driver);
|
|
runwait(rmcmd);
|
|
return -1;
|
|
}
|
|
|
|
int got = runwait(outbin);
|
|
|
|
runwait(rmcmd);
|
|
return got;
|
|
}
|
|
|
|
/* build_should_fail — an overlong array literal must error on `driver`;
|
|
* returns 0 when the build correctly FAILS, non-zero when it wrongly
|
|
* succeeded. */
|
|
static int
|
|
build_should_fail(const char *driver, const char *src, int i)
|
|
{
|
|
char s[128], tmpdir[64], outbin[128], rmcmd[160], cmd[1024];
|
|
snprintf(tmpdir, sizeof tmpdir, "/tmp/oaln_%d_d_%d", getpid(), i);
|
|
mkdir(tmpdir, 0755);
|
|
snprintf(s, sizeof s, "%s/oaln_%d_%d.ww", tmpdir, getpid(), i);
|
|
snprintf(outbin, sizeof outbin, "%s/oaln_%d_%d", tmpdir, getpid(), i);
|
|
snprintf(rmcmd, sizeof rmcmd, "rm -rf %s", tmpdir);
|
|
|
|
FILE *f = fopen(s, "wb");
|
|
if (!f) { runwait(rmcmd); return -1; }
|
|
fputs(src, f);
|
|
fclose(f);
|
|
|
|
/* explicit -o inside tmpdir so the binary AND <stem>.sepwork both land
|
|
* in tmpdir and die with rm -rf (the stem follows the output, not the
|
|
* source). */
|
|
snprintf(cmd, sizeof cmd, "%s build -o %s %s 2>/dev/null",
|
|
driver, outbin, s);
|
|
int rc = runwait(cmd);
|
|
runwait(rmcmd);
|
|
return rc == 0 ? -1 : 0; /* build must NOT succeed */
|
|
}
|
|
|
|
/* asm_byte_identical — w6c vs w6c_ww .s for the same source must match. */
|
|
static int
|
|
asm_byte_identical(const char *bin, const struct row *r, int i)
|
|
{
|
|
char src[64], cs[64], ws[64], cmd[1024];
|
|
snprintf(src, sizeof src, "/tmp/oal_asm_%d_%d.ww", getpid(), i);
|
|
snprintf(cs, sizeof cs, "/tmp/oal_asm_%d_%d_c.s", getpid(), i);
|
|
snprintf(ws, sizeof ws, "/tmp/oal_asm_%d_%d_w.s", getpid(), i);
|
|
|
|
FILE *f = fopen(src, "wb");
|
|
if (!f) return -1;
|
|
fputs(r->src, f);
|
|
fclose(f);
|
|
|
|
snprintf(cmd, sizeof cmd, "%s/w6c -o %s %s 2>/dev/null", bin, cs, src);
|
|
if (runwait(cmd) != 0) {
|
|
fprintf(stderr, "row[%s]: w6c errored\n", r->label);
|
|
unlink(src);
|
|
return -1;
|
|
}
|
|
snprintf(cmd, sizeof cmd, "%s/w6c_ww -o %s %s 2>/dev/null",
|
|
bin, ws, src);
|
|
if (runwait(cmd) != 0) {
|
|
fprintf(stderr, "row[%s]: w6c_ww errored\n", r->label);
|
|
unlink(src); unlink(cs);
|
|
return -1;
|
|
}
|
|
|
|
FILE *fc = fopen(cs, "rb");
|
|
FILE *fw = fopen(ws, "rb");
|
|
int rc = 0;
|
|
if (!fc || !fw) {
|
|
rc = -1;
|
|
} else {
|
|
for (;;) {
|
|
int a = fgetc(fc);
|
|
int b = fgetc(fw);
|
|
if (a != b) { rc = -1; break; }
|
|
if (a == EOF) break;
|
|
}
|
|
}
|
|
if (fc) fclose(fc);
|
|
if (fw) fclose(fw);
|
|
if (rc != 0)
|
|
fprintf(stderr, "row[%s]: cstage vs wwstage asm differs\n",
|
|
r->label);
|
|
unlink(src); unlink(cs); unlink(ws);
|
|
return rc;
|
|
}
|
|
|
|
int
|
|
main(void)
|
|
{
|
|
const char *bin = getenv("BIN");
|
|
if (!bin) bin = "out/bin";
|
|
char absbin[1024];
|
|
if (bin[0] != '/') {
|
|
char cwd[1024];
|
|
if (getcwd(cwd, sizeof cwd) == NULL) return 1;
|
|
snprintf(absbin, sizeof absbin, "%s/%s", cwd, bin);
|
|
bin = absbin;
|
|
}
|
|
|
|
char cdrv[1024];
|
|
snprintf(cdrv, sizeof cdrv, "%s/ww", bin);
|
|
char wdrv[1024];
|
|
snprintf(wdrv, sizeof wdrv, "%s/ww_ww", bin);
|
|
|
|
struct { const char *name; const char *path; int gated_on_existence; }
|
|
drivers[] = {
|
|
{ "cstage", cdrv, 0 },
|
|
{ "wwstage", wdrv, 1 },
|
|
{ NULL, NULL, 0 },
|
|
};
|
|
|
|
int n = (int)(sizeof rows / sizeof rows[0]);
|
|
int nn = (int)(sizeof neg / sizeof neg[0]);
|
|
int total = 0, fail = 0;
|
|
|
|
for (int d = 0; drivers[d].name; d++) {
|
|
if (drivers[d].gated_on_existence
|
|
&& access(drivers[d].path, X_OK) != 0) {
|
|
fprintf(stderr, "overlong_arrlit: skip %s (no %s)\n",
|
|
drivers[d].name, drivers[d].path);
|
|
continue;
|
|
}
|
|
for (int i = 0; i < n; i++) {
|
|
int got = run_driver(drivers[d].path, &rows[i], i);
|
|
total++;
|
|
if (got != rows[i].want) {
|
|
fprintf(stderr,
|
|
"overlong_arrlit[%s][%s]: exit=%d want=%d\n",
|
|
drivers[d].name, rows[i].label,
|
|
got, rows[i].want);
|
|
fail++;
|
|
}
|
|
}
|
|
for (int i = 0; i < nn; i++) {
|
|
total++;
|
|
if (build_should_fail(drivers[d].path, neg[i],
|
|
100 + i) != 0) {
|
|
fprintf(stderr,
|
|
"overlong_arrlit[%s][neg%d]: built ok, "
|
|
"expected a loud error\n",
|
|
drivers[d].name, i);
|
|
fail++;
|
|
}
|
|
}
|
|
}
|
|
|
|
if (access(wdrv, X_OK) == 0) {
|
|
for (int i = 0; i < n; i++) {
|
|
total++;
|
|
if (asm_byte_identical(bin, &rows[i], i) != 0)
|
|
fail++;
|
|
}
|
|
}
|
|
|
|
if (fail) {
|
|
fprintf(stderr,
|
|
"overlong_arrlit: %d/%d fixtures failed\n", fail, total);
|
|
return 1;
|
|
}
|
|
printf("overlong_arrlit: %d/%d ok\n", total, total);
|
|
return 0;
|
|
}
|