/* * 796_xmod_valglobal_dot_run — project #229, the N_DOT-base read + addr-of * sibling of #1 (test 795). Assembly byte-id net for the cross-module * DOTTED value-global miscompile. * * THE BUG (cgen-only, both stages emit IDENTICAL wrong asm → byte-id was * BLIND to it): #1 fixed the DATA def-site and the bare-ident load mangle, * but the DOTTED LOAD/addr sites still used the non-preferring leaf lookup * (cstage masym, wwstage emitsymname). With * package aa; export let v: i32 = 7; * package main; import aa; let v: i32 = 99; main = { return aa.v; } * the `aa.v` read AND `&aa.v` emitted `LEAQ main.v(SB)` — the WRONG * module's global — returning 99, not 7. * * THE FIX (#229): thread the DOTTED module name (the `m` in `m.x`) — NOT * cur_mod — into the existing value mangle at the four lockstep sites: * cstage cgen.c N_DOT read + N_UN addr-of (mahint with n->lhs->str / * opnd->lhs->str), wwstage cgenexpr.ww twins (emitsymnamehint with * lhs.str / basenm). The TY_FN branches beside each site already use this * dotted polarity via mafn/emitfnname; value globals now match. * * Runtime ownership moved to the matching r796_* fixtures. This carrier * retains the w6c vs w6c_ww `.s` comparison required by rule 10. * * GATE POLARITY: a byte-id failure means the stages diverged. */ #include #include #include #include #include static int runwait(const char *cmd) { int rc = system(cmd); if (rc == -1) return -1; if (WIFEXITED(rc)) return WEXITSTATUS(rc); return -1; } struct row { const char *label; const char *src; int want_exit; }; static const struct row rows[] = { /* N_DOT read: aa.v (7) vs private main.v (99). Pre-fix: 99. */ { "i32_dot_read_export_vs_private", "package aa;\n" "export let v: i32 = 7;\n" "package main;\n" "import aa;\n" "let v: i32 = 99;\n" "export fn main() i32 = { return aa.v; };\n", 7 }, /* addr-of: &aa.v then deref. Pre-fix: 99. */ { "i32_addrof_export_vs_private", "package aa;\n" "export let v: i32 = 7;\n" "package main;\n" "import aa;\n" "let v: i32 = 99;\n" "export fn main() i32 = { let p: *i32 = &aa.v; return *p; };\n", 7 }, { NULL, NULL, 0 } }; static int slurp_eq(const char *a, const char *b) { FILE *fa = fopen(a, "rb"); FILE *fb = fopen(b, "rb"); if (!fa || !fb) { if (fa) fclose(fa); if (fb) fclose(fb); return -1; } int rc = 0; for (;;) { int ca = fgetc(fa); int cb = fgetc(fb); if (ca != cb) { rc = -1; break; } if (ca == EOF) break; } fclose(fa); fclose(fb); return rc; } int main(void) { const char *bin = getenv("BIN"); if (!bin) bin = "out/bin"; char absbin[1024]; if (bin[0] != '/') { char cwd[1024]; if (getcwd(cwd, sizeof cwd) == NULL) return 1; snprintf(absbin, sizeof absbin, "%s/%s", cwd, bin); bin = absbin; } char w6c[1100], w6c_ww[1100]; snprintf(w6c, sizeof w6c, "%s/w6c", bin); snprintf(w6c_ww, sizeof w6c_ww, "%s/w6c_ww", bin); if (access(w6c_ww, X_OK) != 0) { fprintf(stderr, "xmod_valglobal_dot: w6c_ww missing — cannot run " "the cs==ww byte-id gate\n"); return 1; } int n = 0, fail = 0; for (int i = 0; rows[i].src; i++, n++) { char tmpdir[64]; snprintf(tmpdir, sizeof tmpdir, "/tmp/wwxmvd_%d_d_%d", getpid(), i); /* an unowned dir must never be rm -rf'd below */ if (mkdir(tmpdir, 0755) != 0) { perror(tmpdir); fail++; continue; } char src[128], cs_s[128], ws_s[128], rmcmd[160]; snprintf(src, sizeof src, "%s/wwxmvd_%d_%d.ww", tmpdir, getpid(), i); snprintf(cs_s, sizeof cs_s, "%s/wwxmvd_%d_%d_cs.s", tmpdir, getpid(), i); snprintf(ws_s, sizeof ws_s, "%s/wwxmvd_%d_%d_ww.s", tmpdir, getpid(), i); snprintf(rmcmd, sizeof rmcmd, "rm -rf %s", tmpdir); FILE *f = fopen(src, "wb"); if (f == NULL) { fail++; if (runwait(rmcmd) != 0) fprintf(stderr, "row[%s]: cleanup failed: %s\n", rows[i].label, rmcmd); continue; } fputs(rows[i].src, f); fclose(f); char cmd[2048]; /* Runtime ownership is r79_xmod_valglobal_dot_*; retain byte-id. */ snprintf(cmd, sizeof cmd, "%s -o %s %s 2>/dev/null", w6c, cs_s, src); if (runwait(cmd) != 0) { fprintf(stderr, "row[%s]: w6c failed\n", rows[i].label); fail++; if (runwait(rmcmd) != 0) fprintf(stderr, "row[%s]: cleanup failed: %s\n", rows[i].label, rmcmd); continue; } snprintf(cmd, sizeof cmd, "%s -o %s %s 2>/dev/null", w6c_ww, ws_s, src); if (runwait(cmd) != 0) { fprintf(stderr, "row[%s]: w6c_ww failed\n", rows[i].label); fail++; if (runwait(rmcmd) != 0) fprintf(stderr, "row[%s]: cleanup failed: %s\n", rows[i].label, rmcmd); continue; } int rowdiff = slurp_eq(cs_s, ws_s) != 0; if (rowdiff) { fprintf(stderr, "row[%s]: cstage/wwstage .s DIFFER " "(rule-10 byte-id violation)\n", rows[i].label); fail++; } /* a leaked tmpdir fails an otherwise-green row without * masking the byte-id verdict. */ if (runwait(rmcmd) != 0) { fprintf(stderr, "row[%s]: cleanup failed: %s\n", rows[i].label, rmcmd); if (!rowdiff) fail++; } } if (fail) { fprintf(stderr, "%d/%d xmod dotted value-global tests failed\n", fail, n); return 1; } printf("xmod_valglobal_dot: %d/%d ok (cs==ww byte-id)\n", n, n); return 0; }