Hojun-Cho/ww
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wwpackage: drop the indexed-source pointer alias

Browse Source 
The task #6 fallback landed; handles[k].result copies and &handles[k]
arguments compile directly, so the WHY-comment alias is dead.
This commit is contained in:
Hojun-Cho
2026-08-08 17:12:48 +09:00
parent d3822d7730
commit 07dfc0e6af
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
internal/wwpackage/package.ww
View File

@@ -912,23 +912,18 @@ export fn packagecommand(args: []str) int = {
let k: i32 = emitted; let k: i32 = emitted;
for (k < launched) { for (k < launched) {
let g: *pkggroup = &groups[k]; let g: *pkggroup = &groups[k];
// Pointer alias: an aggregate copy from if (g.state == PKGBUILDING && exec.poll(&handles[k])) {
// `handles[k].result` (N_DOT over N_INDEX source) is a g.buildres = handles[k].result;
// loud cgen gap in both stages; the deref-base spine is
// wired. Same idiom as wwfixture's collect().
let hp: *exec.process = &handles[k];
if (g.state == PKGBUILDING && exec.poll(hp)) {
g.buildres = hp.result;
if (pkgbuildok(g) && !compileonly) { if (pkgbuildok(g) && !compileonly) {
pkgstartrun(g, filters, timeoutarg, pkgstartrun(g, filters, timeoutarg,
list, hp); list, &handles[k]);
g.state = PKGRUNNING; g.state = PKGRUNNING;
} else { } else {
g.state = PKGDONE; g.state = PKGDONE;
active -= 1; active -= 1;
}; };
} else if (g.state == PKGRUNNING && exec.poll(hp)) { } else if (g.state == PKGRUNNING && exec.poll(&handles[k])) {
g.runres = hp.result; g.runres = handles[k].result;
g.state = PKGDONE; g.state = PKGDONE;
active -= 1; active -= 1;
}; };