Hojun-Cho
dadda19b3a
grabrepeat was an empty body, and under the grab the compositor feeds the client nothing while a key is down: one press, then only repeat_info, leaving the repeat to whoever holds the grab. So a key strans ate acted once however long it was held. Hold Backspace over a syllable and one jamo goes; hold a jamo key and you get one where every other window gives four a second. X11 has none of this -- the server auto-repeats and xim.c dispatches every press -- so the same keyboard behaved differently depending on which frontend the window went through. Under headless sway, which advertises repeat_info(25, 600), holding Backspace 1.5s over 라 with 가가가나다 committed behind it: before preedit 라 -> ㄹ, and no key at the client at all after preedit 라 -> ㄹ -> empty, then 9 BackSpace at the client fcitx5 and kime both keep driving the repeat after the engine stops wanting the key, and both then must send a release before every press, or the client sees a key held down and starts a repeat of its own on top of theirs. That machinery exists only to undo the choice that created it. strans does not need it: forward() already hands a key the engine did not take to the client as a key, and the client repeats that correctly -- the same hold with nothing pending, which takes that untouched path, delivers 24. So the rule is one sentence. strans repeats what the engine takes; when the engine stops taking it, presskey has already passed the key on, the deadline is dropped, and the client repeats it from there. 9 against 24 is that handover: driving every tick here would have made them one number. It costs one pause of the client's own delay, 600ms, where the preedit empties. It buys no release-and-press fiction anywhere in the file, no second repeat engine, and no timestamp arithmetic -- exactly one key is forwarded per hold, so there is no run of stale timestamps to mend. nsec() is gettimeofday, which steps; a deadline wants the clock ipc.c already uses. The owner poll stands down while a key repeats, because the repeat's own Keypress carries our owner and takes the engine back, so it would have nothing to find. Arming needs the engine and cannot be reached from the unit suite; ending a repeat can, and a repeat outliving its key is the worst this could do. wl/repeat-ends was checked by breaking it five ways -- a constant rate, a constant delay, the empty body back again, the key's own release no longer ending it, and a repeat into a dead context staying armed -- each failing only its own line. Phases A-G unchanged at both scales; 90 unit, check-live, check-stress and valgrind clean. One limit worth writing down: the GTK probe prints the BackSpace it receives and never deletes on one, on this path or on the plain pass-through, so the phase proves the keys arrive and says nothing about the text behind them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
131 lines
4.8 KiB
C
131 lines
4.8 KiB
C
/* Included after dat.h and fn.h (or after the source under test). */
|
|
#include "cutest/cutest.h"
|
|
|
|
/*
|
|
* A test's stand-in for imthread: handles engine requests from keyc,
|
|
* tracing each one first. Requests whose op is holdop (every request
|
|
* when holdop is Pumpall) wait on go before the engine sees them.
|
|
*/
|
|
typedef struct Pump Pump;
|
|
struct Pump
|
|
{
|
|
Channel *trace;
|
|
Channel *go;
|
|
Channel *stop;
|
|
Channel *done;
|
|
int holdop;
|
|
int active;
|
|
};
|
|
|
|
enum
|
|
{
|
|
Pumpnone = -1,
|
|
Pumpall = -2,
|
|
};
|
|
|
|
Str mkstr(char*);
|
|
int checkstr(struct ct*, char*, char*, Str*);
|
|
void checkenginepreedit(struct ct*, char*);
|
|
void pumpstart(Pump*, int);
|
|
void pumphold(Pump*, int);
|
|
void pumpstop(Pump*);
|
|
|
|
/* Engine internals reached through engine_test.c. */
|
|
void testengineinit(int);
|
|
void testenginehandle(Keyreq*);
|
|
void* testengineowner(void);
|
|
void testenginepreedit(Str*);
|
|
void testenginecaret(Caret*);
|
|
|
|
void str_init_utf8(struct ct*);
|
|
void str_edit_and_alias(struct ct*);
|
|
void str_utf8_capacity(struct ct*);
|
|
void str_invalid_and_full_appends(struct ct*);
|
|
void trie_exact_prefix_and_duplicate(struct ct*);
|
|
void trie_put_and_unloaded(struct ct*);
|
|
void popup_layout(struct ct*);
|
|
void font_render(struct ct*);
|
|
void production_maps_load(struct ct*);
|
|
void transmap_states(struct ct*);
|
|
void korean_sequences(struct ct*);
|
|
void korean_compound_vowels(struct ct*);
|
|
void korean_compound_finals(struct ct*);
|
|
void korean_backspace(struct ct*);
|
|
void vietnamese_transitions(struct ct*);
|
|
void vietnamese_backspace(struct ct*);
|
|
void vietnamese_state_lifetime(struct ct*);
|
|
void engine_clears_candidates(struct ct*);
|
|
void engine_backspace_clears_candidates(struct ct*);
|
|
void engine_selects_visible_candidate(struct ct*);
|
|
void engine_candidate_shortcut_modifiers(struct ct*);
|
|
void engine_candidate_page_metadata(struct ct*);
|
|
void engine_candidate_page_snapshots(struct ct*);
|
|
void engine_candidate_page_movement(struct ct*);
|
|
void engine_candidate_completion(struct ct*);
|
|
void engine_active_owner_lifecycle(struct ct*);
|
|
void engine_active_owner_reset(struct ct*);
|
|
void engine_active_owner_caret(struct ct*);
|
|
void engine_popup_preedit_capability(struct ct*);
|
|
void engine_vietnamese_client_preedit(struct ct*);
|
|
void engine_commit_contract(struct ct*);
|
|
void engine_language_switch_state(struct ct*);
|
|
void engine_telex_history_bound(struct ct*);
|
|
void engine_korean_modifiers_and_backspace(struct ct*);
|
|
void engine_direct_language_modes(struct ct*);
|
|
void engine_japanese_readings(struct ct*);
|
|
void engine_japanese_candidates(struct ct*);
|
|
void engine_japanese_backspace_and_boundaries(struct ct*);
|
|
void engine_katakana_sequences(struct ct*);
|
|
void engine_emoji_single_candidate(struct ct*);
|
|
void engine_emoji_queries(struct ct*);
|
|
void engine_emoji_japanese_and_multirune(struct ct*);
|
|
void engine_emoji_digit_aliases(struct ct*);
|
|
void engine_emoji_navigation(struct ct*);
|
|
void engine_search_candidate_keys(struct ct*);
|
|
void engine_emoji_preedit_languages(struct ct*);
|
|
void engine_emoji_start_and_unknown(struct ct*);
|
|
void engine_hanja_search(struct ct*);
|
|
void engine_hanja_unknown_and_cancel(struct ct*);
|
|
void engine_hanja_korean_keys(struct ct*);
|
|
void engine_hanja_backspace(struct ct*);
|
|
void engine_hanja_input_languages(struct ct*);
|
|
void engine_randomized_stress(struct ct*);
|
|
void engine_full_boundary_passthrough(struct ct*);
|
|
void dictionary_candidates(struct ct*);
|
|
void dictionary_misses(struct ct*);
|
|
void dictionary_prefix(struct ct*);
|
|
void ipc_masks_modifiers(struct ct*);
|
|
void ipc_control_and_caret_frames(struct ct*);
|
|
void ipc_runtime_path(struct ct*);
|
|
void ipc_response_pack_boundaries(struct ct*);
|
|
void ipc_response_empty_and_preedit(struct ct*);
|
|
void ipc_response_max_and_drain(struct ct*);
|
|
void ipc_response_fragmented_and_truncated(struct ct*);
|
|
void ipc_broken_peer_send(struct ct*);
|
|
void server_connection_ownership(struct ct*);
|
|
void server_extension_stream(struct ct*);
|
|
void server_rejects_unknown_extension(struct ct*);
|
|
void ibus_machine_id_fallback(struct ct*);
|
|
void ibus_capability_policy(struct ct*);
|
|
void ibus_private_input_policy(struct ct*);
|
|
void ibus_context_lifecycle(struct ct*);
|
|
void ibus_active_release_lifecycle(struct ct*);
|
|
void compose_sequences(struct ct*);
|
|
void xim_keymap_lookup(struct ct*);
|
|
void xim_compound_text(struct ct*);
|
|
void xim_adapter_key_contract(struct ct*);
|
|
void xim_adapter_release_lifecycle(struct ct*);
|
|
void xim_adapter_free_waits_for_release(struct ct*);
|
|
void xim_adapter_styles(struct ct*);
|
|
void xim_adapter_placement(struct ct*);
|
|
void xim_adapter_placement_updates(struct ct*);
|
|
void xim_adapter_callback_replacement(struct ct*);
|
|
void xim_adapter_callback_unicode(struct ct*);
|
|
void xim_adapter_callback_cleanup(struct ct*);
|
|
void xim_adapter_callback_transfer(struct ct*);
|
|
void xim_adapter_callback_owner_loss(struct ct*);
|
|
void xim_adapter_commit_encoding(struct ct*);
|
|
void wl_modifier_mask(struct ct*);
|
|
void wl_forwarded_keys(struct ct*);
|
|
void wl_repeat_ends(struct ct*);
|